Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SABnzbd 4.4.1 #6356

Merged
merged 1 commit into from
Dec 25, 2024
Merged

SABnzbd 4.4.1 #6356

merged 1 commit into from
Dec 25, 2024

Conversation

Safihre
Copy link
Contributor

@Safihre Safihre commented Dec 23, 2024

Description

Update SABnzbd to 4.4.1

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@mreid-tt
Copy link
Contributor

hey @Safihre, I noted in the release notes that "macOS and Windows: Use Python 3.13 for release". Would this be a requirement for Linux as well in the near future?

@Safihre
Copy link
Contributor Author

Safihre commented Dec 23, 2024

hey @Safihre, I noted in the release notes that "macOS and Windows: Use Python 3.13 for release". Would this be a requirement for Linux as well in the near future?

No, we support all version in maintained by Python itself, so 3.9 and above.

@Safihre Safihre merged commit 5bff3a5 into SynoCommunity:master Dec 25, 2024
15 checks passed
@Safihre
Copy link
Contributor Author

Safihre commented Dec 25, 2024

@mreid-tt @th0ma7 Unrar needs an update, but it's beyond my very limited makefile knowledge.
I gave it a shot, but failed: https://github.com/Safihre/spksrc/actions
Additionally, for 7zip we still use p7zip which hasn't been updated since 2016.
The regular 7zip also now supports linux, so we could switch to that. But again, beyond my knowledge. https://7-zip.org/download.html

I'd be happy to donate ($200?) to anyone who can do it for me, if anyone is open to that 🙂🎄

@hgy59
Copy link
Contributor

hgy59 commented Dec 25, 2024

@Safihre we can update unrar to v7.1.2, but it will support DSM 7 only (excl. comcerto2k).

And I have succesfully built 7zz of 7zip v24.09 for DSM 7.1 (excl. comcerto2k, excl. armv7).

The limitation to DSM 7.0 (unrar) and DSM 7.1 (7zip) comes from compiler version and AES HW accel. functions.
The build of 7zip for ARMv7-7.1 will probably need a patch.

@mreid-tt
Copy link
Contributor

@hgy59, what would that mean for SABnzbd? Would versions for the older DSM releases just use the older dependencies or would that limit building only for the new DSM releases?

@Safihre
Copy link
Contributor Author

Safihre commented Dec 25, 2024

Ohh, in that case we might want to stick to the older versions for a while..
I don't think we want to drop DSM 6 yet, right?

@mreid-tt
Copy link
Contributor

mreid-tt commented Dec 25, 2024

Well, no we do have some cross/ packages which build different versions depending on the DSM release required for compatibility reasons. I was just trying to confirm if we would be taking a similar approach with unrar and 7zz or if there was some other constraint that would limit things to DSM 7.

@Safihre
Copy link
Contributor Author

Safihre commented Dec 25, 2024

Or we could make them into each their own spk. This way they can first have a DSM 6 compatible release, and all successive ones are DSM 7 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants